Skip to content

fix: show proper message if allowed workflows are not defined in CT#483

Merged
stefinie123 merged 1 commit intoopenchoreo:mainfrom
stefinie123:build-workflow-fix
Mar 23, 2026
Merged

fix: show proper message if allowed workflows are not defined in CT#483
stefinie123 merged 1 commit intoopenchoreo:mainfrom
stefinie123:build-workflow-fix

Conversation

@stefinie123
Copy link
Copy Markdown
Contributor

Purpose

Show a proper warning message if allowedWorkflows are not defined in the ComponentType definition

Screenshot 2026-03-23 at 14 59 23
Screen.Recording.2026-03-23.at.14.58.54.mov

- Added a NotificationBanner to inform users when no build workflows are configured for the selected component type.
- Improved filtering logic to handle allowed workflows more effectively.
- Updated styles for NotificationBanner to enhance visual spacing.

Signed-off-by: Stefinie Fernando <minolispencer@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

Warning

Rate limit exceeded

@stefinie123 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13f959ec-22fb-490a-a309-0c44097f6726

📥 Commits

Reviewing files that changed from the base of the PR and between ccbe6dd and acc5512.

📒 Files selected for processing (2)
  • packages/app/src/scaffolder/BuildWorkflowPicker/BuildWorkflowPickerExtension.tsx
  • plugins/openchoreo-react/src/components/NotificationBanner/styles.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@stefinie123 stefinie123 merged commit acc1059 into openchoreo:main Mar 23, 2026
6 checks passed
mevan-karu pushed a commit to mevan-karu/backstage-plugins that referenced this pull request Mar 27, 2026
…penchoreo#483)

- Added a NotificationBanner to inform users when no build workflows are configured for the selected component type.
- Improved filtering logic to handle allowed workflows more effectively.
- Updated styles for NotificationBanner to enhance visual spacing.

Signed-off-by: Stefinie Fernando <minolispencer@gmail.com>
Signed-off-by: Mevan <mevan.karu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants